[review] QMI LOC improvements and fixes

[Dan Williams]

On Sun, 2018-06-24 at 22:43 +0200, Aleksander Morgado wrote:
> Hey all,
> 
> https://gitlab.freedesktop.org/mobile-broadband/libqmi/merge_requests
> /1
> 
> This MR includes several fixed and improvements in the LOC service
> definition, including support for several qmicli operations.
> 
> As part of the changes, the implementation also adds support for
> receiving QMI indications via QMI over MBIM, but only if requested
> explicitly with a new "open flag" in the QmiDevice, as it involves
> additional setup steps that are not always needed.
> 
> Thomas, this is the branch I started to work on yesterday, which
> would
> obsolete the last patch you sent.
> 
> I'm able to nicely run the qmicli operations even with the modem
> running in MBIM mode. E.g. a simple sequence would be:
> 
> $ sudo qmicli -p -d /dev/cdc-wdm4 --loc-start --client-no-release-cid
> [/dev/cdc-wdm4] Client ID not released:
> Service: 'loc'
>     CID: '2'
> 
> $ sudo qmicli -p -d /dev/cdc-wdm4 --loc-follow-position-report
> --loc-follow-gnss-sv-info--loc-follow-nmea --client-no-release-cid
> --client-cid=2
> ....
> (Ctrl+C)
> 
> $ sudo qmicli -p -d /dev/cdc-wdm4 --loc-stop --client-cid=2
> 
> Comments?

Minor comments on the MR; overall LGTM.

Dan