Patch: add support for qmi_wds_get/set_default_profile_num

[Aleksander Morgado]

Hey!

On Wed, Jun 27, 2018 at 8:11 PM, Wolfgang Tolkien <w at tolkien.email> wrote:
> According to QMI spec  1.38.  Does anybody know what profile family 'embedded' vs. 'tethered' means?
>

No idea really. In which context are you using these?

In several places in the patch: The since tag should reflect which
next stable libqmi version will have the change. It would be "1.22"
now, not "1.8".

See some comments below.

> ---
>
> diff --git a/data/qmi-service-wds.json b/data/qmi-service-wds.json
> index 3c25d3d..bc3db96 100644
> --- a/data/qmi-service-wds.json
> +++ b/data/qmi-service-wds.json
> @@ -1546,6 +1546,57 @@
>                                          "format" : "guint32" } ] } ] },
>
>    // *********************************************************************************
> +  {  "name"    : "Get Default Profile Num",
> +     "type"    : "Message",
> +     "service" : "WDS",
> +     "id"      : "0x0049",
> +     "version" : "1.38",
> +     "since"   : "1.8",
> +     "input"   : [  { "name"          : "Profile Type",
> +                      "id"            : "0x01",
> +                      "mandatory"     : "yes",
> +                      "type"          : "TLV",
> +                      "since"         : "1.8",
> +                      "format"        : "sequence",
> +                      "contents"  : [ { "name"          : "Profile Type",
> +                                        "format"        : "guint8",
> +                                        "public-format" : "QmiWdsProfileType"},
> +                                      { "name"          : "Profile Family",
> +                                        "format"        : "guint8",
> +                                        "public-format" : "QmiWdsProfileFamily"}] }],
> +     "output"  : [  { "common-ref" : "Operation Result" },
> +                    { "name"          : "Default Profile Number",
> +                      "id"            : "0x01",
> +                      "mandatory"     : "yes",
> +                      "type"          : "TLV",
> +                      "since"         : "1.8",
> +                      "format"        : "guint8",
> +                      "prerequisites" : [ { "common-ref" : "Success" } ] } ] },
> +
> +  // *********************************************************************************
> +  {  "name"    : "Set Default Profile Num",
> +     "type"    : "Message",
> +     "service" : "WDS",
> +     "id"      : "0x004A",
> +     "version" : "1.38",
> +     "since"   : "1.8",
> +     "input"   : [  { "name"          : "Profile Identifier",
> +                      "id"            : "0x01",
> +                      "mandatory"     : "yes",
> +                      "type"          : "TLV",
> +                      "since"         : "1.8",
> +                      "format"        : "sequence",
> +                      "contents"  : [ { "name"          : "Profile Type",
> +                                        "format"        : "guint8",
> +                                        "public-format" : "QmiWdsProfileType"},
> +                                      { "name"          : "Profile Family",
> +                                        "format"        : "guint8",
> +                                        "public-format" : "QmiWdsProfileFamily"},
> +                                      { "name"          : "Profile Index",
> +                                        "format"        : "guint8"}] }],
> +     "output"  : [  { "common-ref" : "Operation Result" } ] },
> +
> +  // *********************************************************************************
>    {  "name"    : "Set IP Family",
>       "type"    : "Message",
>       "service" : "WDS",
> diff --git a/src/libqmi-glib/qmi-enums-wds.h b/src/libqmi-glib/qmi-enums-wds.h
> index f1f84c0..b010318 100644
> --- a/src/libqmi-glib/qmi-enums-wds.h
> +++ b/src/libqmi-glib/qmi-enums-wds.h
> @@ -1297,6 +1297,22 @@ typedef enum { /*< underscore_name=qmi_wds_profile_type >*/
>      QMI_WDS_PROFILE_TYPE_3GPP2   = 1
>  } QmiWdsProfileType;
>
> +
> +/**
> + * QmiWdsProfileFamily:
> + * @QMI_WDS_PROFILE_FAMILY_EMBEDDED: Embedded profile family.
> + * @QMI_WDS_PROFILE_FAMILY_TETHERED: Tethered profile family.
> + *
> + * Profile family.
> + *
> + * Since: 1.8

The since tag should reflect which next stable libqmi version will
have the change. It would be "1.22" now.

> + */
> +typedef enum { /*< underscore_name=qmi_wds_profile_family >*/
> +    QMI_WDS_PROFILE_FAMILY_EMBEDDED = 0,
> +    QMI_WDS_PROFILE_FAMILY_TETHERED = 1
> +} QmiWdsProfileFamily;
> +

The new enum should have been placed after the
qmi_wds_profile_type_get_string() documentation below. And also, the
new enum would need its own qmi_wds_profile_family_get_string()
documentation block.

> +
>  /**
>   * qmi_wds_profile_type_get_string:
>   *
> _______________________________________________
> libqmi-devel mailing list
> libqmi-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libqmi-devel



-- 
Aleksander
https://aleksander.es