[review] EM75xx firmware update using qmi-firmware-update

[Aleksander Morgado]

>
> thank you for working on this. After applying this patch
>
> diff -U1 -p src/qmi-firmware-update/qfu-sahara-device.c{.~1~,}
> --- src/qmi-firmware-update/qfu-sahara-device.c.~1~     2019-06-27 15:05:49.956544390 +0200
> +++ src/qmi-firmware-update/qfu-sahara-device.c 2019-06-27 15:53:51.544031910 +0200
> @@ -1102,3 +1102,3 @@ sahara_device_run_protocol_step (QfuSaha
>      SaharaProtocolStep  next_step = SAHARA_PROTOCOL_STEP_UNKNOWN;
> -    gsize               reqlen;
> +    gsize               reqlen = 0;
>      gssize              rsplen;
>

Ah, due to the g_assert_not_reached() being optionaly enabled or not.
I've added your patch now :) thanks


> to fix compilation with -Wsometimes-uninitialized I could successfully
> update an EM7565 from
>
>    original firmware revision was:
>       SWI9X50C_01.08.04.00 dbb5d0 jenkins 2018/08/21 21:40:11
>    original running firmware details:
>       Model: EM7565
>       Boot version: SWI9X50C_01.08.04.00
>       AMSS version: SWI9X50C_01.08.04.00
>       SKU ID: 1104207
>       Carrier ID: 1
>       Config version: 002.011_000
>    original firmware preference details:
>       image 'modem': unique id '002.011_000', build id '01.08.04.00_GENERIC'
>       image 'pri': unique id '002.011_000', build id '01.08.04.00_GENERIC'
>
> to the new firmware
>
>    new firmware revision is:
>       SWI9X50C_01.09.04.00 6d3218 jenkins 2019/02/26 20:33:22
>    new running firmware details:
>       Model: EM7565
>       Boot version: SWI9X50C_01.09.04.00
>       AMSS version: SWI9X50C_01.09.04.00
>       SKU ID: 1104207
>       Carrier ID: 1
>       Config version: 002.019_000
>    new firmware preference details:
>       image 'modem': unique id '002.019_000', build id '01.09.04.00_GENERIC'
>       image 'pri': unique id '002.019_000', build id '01.09.04.00_GENERIC'
>
> announced here
> https://forum.sierrawireless.com/t/em7565-aggregating-b1-b3-does-not-work-as-expected/13861/43
> yesterday.
>

Superb! I didn't even try that myself :D

-- 
Aleksander
https://aleksander.es