Missing NULL checks - qmi-proxy.c

[Peter Naulls]

On 12/30/20 7:20 AM, Aleksander Morgado wrote:

> 
> That fix is in the mmcli, not in the daemon; probably unrelated :)
> But if you can try with git master, it would be great. I try to
> backport clear fixes to the latest stable branch, but it may happen
> that I miss some.

Ah yes.  This is what I see at OpenWrt shutdown with latest git ModemManager:


root at OpenWrt:/# Thu Dec 31 16:25:09 2020 daemon.info procd: - shutdown -
Thu Dec 31 16:25:09 2020 authpriv.info dropbear[3047]: Early exit: Terminated by 
signal
Failed to find log object: Not found
[  235.555695] br-lan: port 1(eth0.1) entered disabled state
[  235.571799] device eth0.1 left promiscuous mode
[  235.580928] device eth0 left promiscuous mode
[  235.589950] br-lan: port 1(eth0.1) entered disabled state
[  235.604226] IPv6: ADDRCONF(NETDEV_UP): eth0.1: link is not ready
[  235.702430] mtk_soc_eth 1e100000.ethernet: 0x100 = 0x6060000c, 0x10c = 0x80818
Failed to find log object: Not found
Failed to find log object: Not found
[  237.483960] do_page_fault(): sending SIGSEGV to ModemManager for invalid read 
access from 00000000
[  237.501884] epc = 7781e4f5 in libglib-2.0.so.0.6600.3[777bf000+f5000]
[  237.514939] ra  = 00432e7f in ModemManager[400000+f3000]
Failed to find log object: Connection failed
[  240.505942] reboot: Restarting system

Whether it's important to general operation, I don't know.  Bit of a tricky time
to debug, but probably triggered by something else shutting down.