qmi-proxy being deleted after use

[Dan Williams]

On Wed, 2025-01-22 at 19:08 +0100, Bjørn Mork wrote:
> Kasper Cheng <kaspercheng77 at gmail.com> writes:
> 
> > Attached is a trace log from raspberry 5's apt install of qmi-proxy
> > 1.32.2,
> > and a latest git build I made yesterday.
> > Both logs show a call to unlinkat() at the end.
> > Does it mean that it is expected for the user to copy qmi-proxy to
> > a temp
> > folder before use, and qmi-proxy clean itself up on exit?
> 
> The dispose() method in libqmi-glib/qmi-proxy.c calls
> 
>  g_unlink (QMI_PROXY_SOCKET_PATH)
> 
> and we have
> 
>  #define QMI_PROXY_SOCKET_PATH "qmi-proxy"
> 
> so I guess the behaviour is expected if you run qmi-proxy from the
> directory where the binary is located.
> 
> But it doesn't really make sense.  The socket name is "\0qmi-proxy"
> AFAIK. So what exactly is this trying to unlink?
> 

Been that way since 2013. But yeah, seems wrong since abstract sockets
don't exist in the filesystem.

https://gitlab.freedesktop.org/mobile-broadband/libqmi/-/merge_requests/390

Mind reviewing (Bjorn or anyone)?

Thanks,
Dan



> 
> 
> Bjørn
> 
>