<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Hey Aleksander,<br></div><div class="gmail_extra"><br><div class="gmail_quote">On 9 November 2017 at 15:56, Dan Williams <span dir="ltr"><<a href="mailto:dcbw@redhat.com" target="_blank">dcbw@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-">On Thu, 2017-11-09 at 08:32 +0100, Aleksander Morgado wrote:<br>
> Hey,<br>
><br>
> Most TLVs in the QMI protocol used a 64bit mask to flag the list of<br>
> LTE bands, and therefore there was no way to reference bands greater<br>
> than 64. These patches include support for additional TLVs that allow<br>
> managing those bands.<br>
><br>
> In particular, these patches include support for managing band 66 in<br>
> QMI devices that support it, like the Telit LM940.<br>
><br>
> [PATCH 1/3] nas: define additional LTE bands<br>
> [PATCH 2/3] dms: new 'Extended LTE Band Capability' TLV in "Get<br>
> Band...<br>
> [PATCH 3/3] nas: new 'Extended LTE Band Preference' TLV in<br>
> "Set/Get...<br>
><br>
> Comments?</span></blockquote><div><br></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">I tested the patch on a LM940 and looks good to me as well. Only two observation:<br><br>1. LM940 with *nas-get-system-selection-preference* returns an unexpected pair of bands 252 and 255. Not sure if it is a modem error or some kind of valid information, do you have any idea?<br><br><<<<<< TLV:<br><<<<<< type = "Extended LTE Band Preference" (0x23)<br><<<<<< length = 32<br><<<<<< value = DF:18:09:3B:A0:01:00:00:02:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:48<br><<<<<< translated = [ mask_low = '1787696847071' mask_mid_low = '2' mask_mid_high = '0' mask_high = '5188146770730811392' ]<br><br>[/dev/cdc-wdm1] Successfully got system selection preference<br> Emergency mode: 'no'<br> Mode preference: 'umts'<br> Band preference: 'wcdma-2100, wcdma-pcs-1900, wcdma-1700-us, wcdma-850-us, wcdma-900'<br> LTE band preference: '1, 2, 3, 4, 5, 7, 8, 12, 13, 17, 20, 25, 26, 28, 29, 30, 38, 40, 41'<br> LTE band preference (extended): '1, 2, 3, 4, 5, 7, 8, 12, 13, 17, 20, 25, 26, 28, 29, 30, 38, 40, 41, 66, 252, 255'<br> TD-SCDMA band preference: 'a, b, c, d, e, f'<br> Roaming preference: 'any'<br> Network selection preference: 'automatic'<br> Service domain preference: 'cs-ps'<br> Service selection preference: 'automatic'<br><br><br>2. dms-get-bands-capability's ouput is hard to read<br><br>[/dev/cdc-wdm1] Device band capabilities retrieved:<br> Bands: 'wcdma-2100, wcdma-pcs-1900, wcdma-dcs-1800, wcdma-1700-us, wcdma-850-us, wcdma-900'<br> LTE bands: '1, 2, 3, 4, 5, 7, 8, 12, 13, 17, 20, 25, 38, 40, 41'<br> LTE bands (extended): '123457812131720252628293038404166'<br><br>I updated the second patch to have a slighly better readability (patches are in attachment)<br><br>[/dev/cdc-wdm1] Device band capabilities retrieved:<br> Bands: 'wcdma-2100, wcdma-pcs-1900, wcdma-dcs-1800, wcdma-1700-us, wcdma-850-us, wcdma-900'<br> LTE bands: '1, 2, 3, 4, 5, 7, 8, 12, 13, 17, 20, 25, 38, 40, 41'<br> LTE bands (extended): '1, 2, 3, 4, 5, 7, 8, 12, 13, 17, 20, 25, 26, 28, 29, 30, 38, 40, 41, 66'</div></div><br></div></div>