[Libreoffice-bugs] [Bug 36217] Wrong env variable handling in _imp_setProcessLocale

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=36217

Jan Holesovsky <kendy at suse.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Jan Holesovsky <kendy at suse.cz> 2011-04-14 16:24:48 PDT ---
Christian: Thank you very much for your patch!  Can you please confirm that it
is LGPL3 / MPL licensed?

You are right, the LC_CTYPE setting smells a copy'n'paste ;-)  The thing is
that this seems not to be compiled at all on LINUX || SOLARIS || NETBSD ||
FREEBSD || OPENBSD || DRAGONFLY - ure/sal/osl/os2 is OS/2-related only (I
suspect a platform we do not support any more), and the _imp_setProcessLocale()
in unx/nlsupport.c is actually compiled only in !(LINUX || SOLARIS || NETBSD ||
FREEBSD || OPENBSD || DRAGONFLY) case - so only the #if defined(AIX) has any
value in the original code.

Either way - I fixed it to build, minimized it, and pushed as:

http://cgit.freedesktop.org/libreoffice/ure/commit/?h=libreoffice-3-4&id=e75d09e4e89d3eda7ddaa2c085678edf9a21293f

:-)  Please send your further patches directly to the
libreoffice at lists.freedesktop.org, ideally as the result of git format-patch,
so that we have even your name / email address right.  More info here:

http://wiki.documentfoundation.org/Development/Patch_Handling_Guideline

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.