[Libreoffice-bugs] [Bug 42100] EasyHack: calc sheet tab widget screen space usage

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=42100

--- Comment #19 from Kohei Yoshida <kohei.yoshida at gmail.com> 2012-04-27 08:25:54 PDT ---
(In reply to comment #18)
> Created attachment 60503 [details] [review]
> diff of the fixes, updated to fix the problem Kohei mentioned
> 
> Ok, here is a new patch with the problem that Kohei mentioned fixed.
> 
> I tried it out by applying it to a slightly older version because the current
> master doesn't build for me (on fedora right now).

Hello Forest,

This patch is definitely in the right direction.  I can see different width of
the visible area depending on the tab count.  I can still see two issues:

1) the width is still not wide enough to show all tabs (including the '+' tab)
when the window is not maximized.  Especially when you set the initial sheet
number to, say, 6, only the first 5 sheet tabs are visible.

2) The patch ignores custom width set by the document.  See Comment 4 for
details.

BTW, this is not a major issue, but it would be great if you could create your
patch by git format-patch, rather than git diff.  See this page

http://wiki.documentfoundation.org/Development/Patch_Handling_Guideline

for general guidelines that we follow.  It's not mandatory, but it would make
our job a bit easier when applying patches.

Thanks a lot!  Sorry it took a little while for me to review.

Kohei

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.