[Libreoffice-bugs] [Bug 35663] complex.sfx2.UndoManager fails

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=35663

--- Comment #12 from Kohei Yoshida <kohei.yoshida at gmail.com> 2012-07-10 13:21:16 PDT ---
(In reply to comment #11)
> ah there is already a bug about this; so indeed only the Calc part
> of the UndoManager test fails.
> 
> note that last week some commits from CWS fs34b were merged that
> changed the SfxUndoManager to no longer count the DisableUndo calls
> but instead maintain a simple boolean flag.
> 
> Kohei, could you please check if that changes anything for
> Calc, and if you can make the test work again?

I re-enabled the test and ran make check, but I still get this:

finished class: complex.sfx2.UndoManager
--------------------------------------------------------------------------------

Time: 14.171
There was 1 failure:
1) checkCalcUndo(complex.sfx2.UndoManager)
java.lang.AssertionError: Undo manager gets unlocked as a side effect of
performing a simple operation
    at complex.sfx2.UndoManager.impl_testLocking(UndoManager.java:774)
    at complex.sfx2.UndoManager.impl_checkUndo(UndoManager.java:630)
    at complex.sfx2.UndoManager.checkCalcUndo(UndoManager.java:125)

FAILURES!!!
Tests run: 12,  Failures: 1

So, I guess the coast is not yet clear.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.