[Libreoffice-bugs] [Bug 39440] cppcheck cleanliness

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Jul 24 09:08:13 CEST 2012


https://bugs.freedesktop.org/show_bug.cgi?id=39440

--- Comment #12 from David Tardon <dtardon at redhat.com> 2012-07-24 07:08:13 UTC ---
(In reply to comment #11)
> Created attachment 64577 [details] [review]
> Patch to fix C-style Cast

Some notes:

1. Please do not send whole changed files; use git format-patch to get a patch

2. Please do not attach patches to bugzilla, especially not partial fixes for
long-living bugs like this one. Either send them to
libreoffice at lists.freedesktop.org (with [PATCH] in subject) or use gerrit
(https://wiki.documentfoundation.org/Development/gerrit)

3. Your fix is actually wrong. The pointer is tested for being non-null at the
following line, which implies that the cast can fail. That again implies that
dynamic_cast must be used.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the Libreoffice-bugs mailing list