[Libreoffice-bugs] [Bug 108580] Cannot run LibreOffice, api-ms-win-crt-runtime-l1-1-0.dll is missing ( for local solution see comment 7)

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=108580

Mike Kaganski <mikekaganski at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |d.ostrovsky at gmx.de
           See Also|                            |https://bugs.documentfounda
                   |                            |tion.org/show_bug.cgi?id=10
                   |                            |5311

--- Comment #8 from Mike Kaganski <mikekaganski at hotmail.com> ---
As documentation states, [1] if a directory name *starts with* one of
predefined SystemFolder properties, a CustomAction type 51 is generated for it.
"It does not verify that the directory name exactly equals the directory
property. Any directory beginning with one of these standard folder names gets
a type 51 custom action, even if the rest of the name is not a GUID."

Our fix for bug 105311 follows this description literally. But my concern is if
we are victims of another MS documentation flaw. I mean, the passage "The
tables in the merge module must reference the location of a child directory of
TARGETDIR, *or another directory in the merge module's tree*" in the mentioned
documentation page (emphasis mine).

The C-Runtime merge module has two directories in it, named

SystemFolder.E281B893_10D7_34CE_BB0E_B69D88E154A5
and
SystemFolder_x86_VC.E281B893_10D7_34CE_BB0E_B69D88E154A5

The former has its parent set to TARGETDIR, and the latter has its parent set
to former (SystemFolder.E281B893_10D7_34CE_BB0E_B69D88E154A5). I.e., they form
a hierarchy (though the latter doesn't define any subdirectory).

But we generate two custom actions for both of them, because they both do begin
with "SystemFolder". Thus, we may break the hierarchy (that's my guess).
Intuitively, this shouldn't break things, as we still point both to a proper
location, but who knows.

Could it be that MS documentation must be read as "if directory name *before
dot* is equal to one of pre-defined SystemFolder properties, ..."?

Adding David Ostrovsky (the author of fix for bug 105311, and expert in this
area) to CC list.

[1] https://msdn.microsoft.com/en-us/library/windows/desktop/aa367787

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20170811/b2ecc06f/attachment.html>