[Libreoffice-bugs] [Bug 105500] Small but noticeable lag when selecting shapes with sidebar enabled

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=105500

--- Comment #12 from Julien Nabet <serval2412 at yahoo.fr> ---
(In reply to Alex Thurgood from comment #10)
> In addition, there is also:
> 
> tbcontrl.cxx, lines 3235-3236:
> 
> void SvxColorListBox::EnsurePaletteManager()
> {
>     if (!m_xPaletteManager)
>     {
>         m_xPaletteManager.reset(new PaletteManager);
>         m_xPaletteManager->SetColorSelectFunction(m_aColorWrapper);
>         m_xPaletteManager->SetLastColor(m_aSelectedColor.first);
>     }
> }

I think we should add m_xPaletteManager.reset(nullptr);
in SvxColorToolBoxControl::~SvxColorToolBoxControl (see
https://opengrok.libreoffice.org/xref/core/svx/source/tbxctrls/tbcontrl.cxx#2800)

BTW, perhaps m_xPaletteManager from colorbox.hxx could be deleted since it
seems unused.

Here too, I'll be able to submit a patch about it tonight if nobody does it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20170817/0ef2a2a2/attachment.html>