[Libreoffice-bugs] [Bug 110742] add support for user icon themes via extension manager

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=110742

--- Comment #5 from Markus Mohrhard <markus.mohrhard at googlemail.com> ---
(In reply to admin from comment #4)
> (In reply to andreas_k from comment #3)
> > So if I get an mentor I will do it.
> 
> Currently the standard icon search path is hardcoded to $BRAND_BASE_DIR and
> returned from this static method:
> IconThemeScanner::GetStandardIconThemePath().
> 
> It is then used in settings.cxx to instantiate mIconThemeScanner for class
> ImplStyleDate. The default theme is set using
> StyleSettings::GetAutomaticallyChosenIconTheme().
> Here's a list of relevant files that will help you get around:
> 
> vcl/source/app/settings.cxx
> vcl/source/app/IconThemeScanner.cxx
> vcl/source/app/IconTheme*.cxx
> 
> As for the actual proper way of changing this to also look in the
> $USER/libreoffice dir, I'm going to leave it to someone who is well versed
> on theme/ui code to advise you on the best approach. If you start working on
> this please assign it to you. Thank you!

Most likely the simplest solution is to always handle a std::vector<OUString>
for GetStandardIconThemePath and the IconThemeScanner::Create

This is a really simple and quick change.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20170831/b6c553b0/attachment-0001.html>