[Libreoffice-bugs] [Bug 114229] Basic -timeserial function minutes outside the range 0-59

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=114229

--- Comment #4 from Mike Kaganski <mikekaganski at hotmail.com> ---
Actually, it's that way since day 1 (see
https://cgit.freedesktop.org/libreoffice/core/commit/?id=c25ec060; look for
RTLFUNC(TimeSerial)).

Fixing the code to conform to help is trivial (code is in
basic/source/runtime/methods.cxx:2001, void SbRtl_TimeSerial(StarBASIC *,
SbxArray & rPar, bool)). But first, it should be clear that the code must be
fixed, and not the help. And if the code is to be fixed, then what to do in
cases (not covered in help) when hour is in allowed range, and minutes are so
that resulting hour becomes outside of the range. Should we allow that? if so,
how to go with that, and why should we block hours outside of the range, if
this can be processed in a sensible way?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20171204/808e6333/attachment.html>