[Libreoffice-bugs] [Bug 114484] Make internal file and print dialogs obsolete

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=114484

Heiko Tietze <tietze.heiko at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |xiscofauli at libreoffice.org
           Assignee|tietze.heiko at gmail.com      |libreoffice-bugs at lists.free
                   |                            |desktop.org

--- Comment #2 from Heiko Tietze <tietze.heiko at gmail.com> ---
Simple access vi UI is hidden with the patch, Tools > Options > Advanced >
Expert > org.openoffice.Office.Common.Misc > UseSystemFileDialog can still be
used to enable or disable. Regardless this option the internal dialogs will
also be shown for SAL_USE_VCLPLUGIN=gen and are relevant for headless mode.

Some code pointers to clean up later (would keep the ticket open):
svtools/source/config/miscopt.cxx
include/svtools/miscopt.hxx
cui/source/options/optgdlg.cxx
cui/source/options/optgdlg.hxx
desktop/source/app/app.cxx
svtools/source/uno/fpicker.cxx

The internal print dialog is still enabled, however the respective field is
hidden with code.

OfaMiscTabPage::OfaMiscTabPage(vcl::Window* pParent, const SfxItemSet& rSet)
    : SfxTabPage(pParent, "OptGeneralPage", "cui/ui/optgeneralpage.ui", &rSet)
{
    get(m_pExtHelpCB, "exthelp");
    if (!lcl_HasSystemFilePicker())
        get<VclContainer>("filedlgframe")->Hide();
#if ! ENABLE_GTK
    get<VclContainer>("printdlgframe")->Hide();
#else
    if (!SvtMiscOptions().IsExperimentalMode())
    {
        get<VclContainer>("printdlgframe")->Hide();
    }
#endif

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20171215/56847353/attachment.html>