[Libreoffice-bugs] [Bug 114251] Hang loading spreadsheet

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=114251

--- Comment #4 from Eike Rathke <erack at redhat.com> ---
(In reply to Eike Rathke from comment #3)
> The worst part then is the SoftwareInterpreter nonsense because it has no
> clue about the semantics of ranges and implicit intersections (which this
> document heavily uses) and the implications of arrays, and blindly replaces
> every range encountered with an array, forcing calculations to array mode
> where they should not, e.g. matrix divisions of entire columns just to pick
> one result element and throw a million away.
> 
> Even more necessarily the SoftwareInterpreterFunc::operator() needs to be
> taught when to replace a range with an array and when not.

I was wrong on this. Actually it is ScGroupTokenConverter::convert() (called
from ScFormulaCell::InterpretFormulaGroup()) that blindly forces the array.
SoftwareInterpreterFunc::operator() only takes the generated
formula::svDoubleVectorRef to create the matrix tokens.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20171216/b1b7bd25/attachment-0001.html>