[Libreoffice-bugs] [Bug 110743] Crash on new master page, if first master page has image as background

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=110743

Xisco Faulí <xiscofauli at libreoffice.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |bibisected, bisected,
                   |                            |regression
             Status|UNCONFIRMED                 |NEW
                 CC|                            |pranavk at collabora.co.uk
           Hardware|x86 (IA32)                  |All
            Version|6.0.0.0.alpha0+ Master      |5.4.0.0.alpha1+
     Ever confirmed|0                           |1
                 OS|Windows (All)               |All

--- Comment #1 from Xisco Faulí <xiscofauli at libreoffice.org> ---
Regression introduced by:

author  Pranav Kant <pranavk at collabora.co.uk>   2017-04-23 09:24:42 (GMT)
committer       pranavk <pranavk at collabora.co.uk>       2017-05-01 04:46:19
(GMT)
commit  c454fbb9b62164d5f047990ae63522c9fb932086 (patch)
tree    682c263be6e283fd4ad04e509548abd520595f16
parent  862b6c0a32dfce924bfafa84acaed47c5380fc46 (diff)
sd: Use unique Page ids for better multi-view support + unit test
... instead of using simple IDs which are assumed to be one greater than
the slide position everywhere in the codebase.

Use a 16 bit static counter and uniquely assign page ids to SdPage
objects. This helps in identifying which slide was already selected
in second view before any slide is deleted in the first view. Otherwise,
using simple positions to keep track of it leads the second view to end
up selecting the wrong slide after any slide is added or removed in the
first view.

Bisected with bibisect-linux-64-5.4

Adding Cc: to Pranav Kant

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20170731/36f02a96/attachment.html>