[Libreoffice-bugs] [Bug 105316] Crash in OutputDevice::InitLineColor() when stressing the Select Theme Categories

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=105316

--- Comment #6 from Michael Meeks <michael.meeks at collabora.com> ---
Wow this is bad:

#18 0x00002aaab466c8a7 in Button::SetModeImage (this=0x55555bfea100,
rImage=...) at /home/julien/lo/libreoffice/vcl/source/control/button.cxx:178
#19 0x00002aaaf99fd828 in SelectPersonaDialog::ClearSearchResults
(this=0x55555ba85680) at
/home/julien/lo/libreoffice/cui/source/options/personalization.cxx:261
#20 0x00002aaaf9a00707 in SearchAndParseThread::execute (this=0x55555bf45410)
at /home/julien/lo/libreoffice/cui/source/options/personalization.cxx:680
#21 0x00002aaaaf506ed8 in salhelper::Thread::run (this=0x55555bf45410) at
/home/julien/lo/libreoffice/salhelper/source/thread.cxx:40

We should never call random VCL methods like Button::SetModeImage from a thread
without first taking the Solar Mutex - that is what is caught here ...

Quite probably we should add more of these checks to random Window:: methods to
ensure that the correct thread is running =)

I imagine this is the root of the crash.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20170525/77c16f73/attachment.html>