[Libreoffice-bugs] [Bug 108115] New: Merging registry modules can overflow

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=108115

            Bug ID: 108115
           Summary: Merging registry modules can overflow
           Product: LibreOffice
           Version: Inherited From OOo
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: medium
         Component: LibreOffice
          Assignee: libreoffice-bugs at lists.freedesktop.org
          Reporter: chris.sherlock79 at gmail.com

In the registry module, if you have two sets of registry "modules" (keys and
subkeys) then you can potentially cause an overflow condition in
ORegistry::mergeModuleValue().

That's because a RegistryTypeWriter has a capacity of (2^16 - 1), but when this
function merges there can potentially be more than (2^16 - 1) values it tries
to insert.

We need to either insert check that the total number of values to be inserted
aren't going to be more than (2^16 -1) and give RegError::NO_ERROR, or we need
to insert the original values, then insert the rest of the values and return a
new error value RegError::PARTIAL_MERGE

I favour the latter, as we are sort of doing this already in the code, only we
don't warn it is a partial merge.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20170526/ab4fe019/attachment.html>