[Libreoffice-bugs] [Bug 113647] Crash when clicking 2 times on "New Theme..." in Gallery on detached SideBar ( steps in comment 4 ) ( not gtk3)

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=113647

Xisco Faulí <xiscofauli at libreoffice.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |bibisected, bisected,
                   |                            |regression
           Priority|medium                      |highest
                 CC|                            |noelgrandin at gmail.com
            Version|6.0.0.0.alpha1+ Master      |5.3.0.0.alpha1+
            Summary|Crash when clicking 2 times |Crash when clicking 2 times
                   |on "New Theme..." in        |on "New Theme..." in
                   |Gallery on detached SideBar |Gallery on detached SideBar
                   |( steps in comment 4 )      |( steps in comment 4 ) (
                   |                            |not gtk3)
           Severity|normal                      |critical

--- Comment #6 from Xisco Faulí <xiscofauli at libreoffice.org> ---
Actually, the commits fixing bug 105017,
a076a062ceb02bd34a460819db61dcbfbca5c8d7 and
cd9d8315141c3070f43e145ed4ee390e837eb73f, fixed the issue in GTK3 but not in
the other platforms.

First it started crashing after:

author  Noel Grandin <noel at peralex.com> 2016-09-21 12:48:15 (GMT)
committer       Noel Grandin <noel.grandin at collabora.co.uk>     2016-10-27
06:08:30 (GMT)
commit  eca5ea9f79181d45cd7fbabe2313617d3025818a (patch)
tree    10b5837fe04212349825742b38f5a37be9ce7009
parent  bbd44f8f89839b5abb4ec6c7ea195431de5b2f48 (diff)
make the AbstractDialog stuff extend from VclReferenceBase
Because some stuff wants to multiple-inherit from VclAbstractDialog and
OutputDevice-subclasses, and we'd prefer to keep all the lifetime
management through a single smart pointer class (VclPtr)

The change in msgbox.cxx and window.cxx is to workaround a bug in
VS2013 to do with virtual inheritance and delegating constructors.

and then it changed to two clicks after:

author  Noel Grandin <noel.grandin at collabora.co.uk>     2016-11-10 10:53:02
(GMT)
committer       Noel Grandin <noel.grandin at collabora.co.uk>     2016-11-11
06:55:41 (GMT)
commit  78b4a1fb01af9ad3b3395a22f6e396be914b553e (patch)
tree    846fdaea907a70fdc274a1e76642ed5e06622c0d
parent  071e23fee07b92b8f07800cda3ca7e66afe818ae (diff)
update vclwidget loplugin to find ref-dropping assigment
Look for places where we are accidentally assigning a returned-by-value
VclPtr<T> to a T*, which generally ends up in a use-after-free.

Adding Cc: to Noel Grandin

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20171106/5ac0de1a/attachment-0001.html>