[Libreoffice-bugs] [Bug 112689] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=112689

Stephan Bergmann <sbergman at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sbergman at redhat.com

--- Comment #9 from Stephan Bergmann <sbergman at redhat.com> ---
(In reply to Muhammet Kara from comment #2)
> Please also note that this easyhack is not meant for O(U)StringBuffer's
> inside loops.

And also note that these changes are only really beneficial if the resulting
OUString is created in one go,

  OUString s = ... + ... + ... + ...;

Replacing existing piecemeal OUStringBuffer construction with

  OUString s = ...;
  ...
  s += ...;
  ...
  s += ...;
  ...
  s += ...;

isn't that useful (and potentially has negative impacts on memory usage).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20171123/429c82e6/attachment.html>