[Libreoffice-bugs] [Bug 78067] Poor ODP save caused by swapping in all images (pointlessly)

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=78067

Michael Stahl <mstahl at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mstahl at redhat.com
         Whiteboard|                            |perf

--- Comment #5 from Michael Stahl <mstahl at redhat.com> ---
this should be substantially improved with:

commit a03a0cfb1e41c357950a40623c2f8b6f5507e97d
Author:     Michael Stahl <mstahl at redhat.com>
AuthorDate: Fri Jul 14 14:32:22 2017 +0200

    sw: make SwGrfNode::mpReplacementGraphic swappable

    Same as previous commit, but for sw.

    Change-Id: Id678de3f512204437e37aaedf24e24aff7a9e592

commit c96e3e226fe4eb8f25c54cce4d653d12eda63ce2
Author:     Michael Stahl <mstahl at redhat.com>
AuthorDate: Wed Jul 12 15:14:48 2017 +0200

    svx: make SdrGrafObj::mpReplacementGraphic swappable

    These GraphicObjects clog up the GraphicManager cache so it's
    effectively useless.

    Round-tripping the ML bugdoc, this doesn't provide much of a
    speed-up by itself, but together with the previous fix it goes from
    3:00 to 1:30 (in an optimized build).

    Change-Id: If52e176c790b94ffef9984be53376a34345b06e3

commit b3992ddcd13082a934246b717ae22f57394e6533
Author:     Michael Stahl <mstahl at redhat.com>
AuthorDate: Thu Jul 13 21:58:48 2017 +0200

    xmloff: ODF export: fix redundant setting of GraphicStreamURL swapping

    XMLShapeExport::ImpExportGraphicObjectShape() unnecessarily swaps out
    the GraphicObject by calling setPropertyValue("GraphicStreamURL")
    even if the URL didn't actually change from what was retrieved
    just a couple lines earlier, incidentally swapping it in too.

    Well actually it isn't really swapped out, it's marked as auto-swapped,
    but nevertheless on getting the "ReplacementGraphicURL" property
    its Graphic will be replaced by swapping it in again.

    So don't do that, then it's only swapped in once.

    This speeds up round-tripping the ML bugdoc from 3:20 to 3:00.

    Change-Id: I65a211a0c225444c06d5516df9c6716360be46c0

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20171123/8cf51538/attachment.html>