[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #13 from Telesto <telesto at surfxs.nl> ---
Created attachment 136759
  --> https://bugs.documentfoundation.org/attachment.cgi?id=136759&action=edit
Bibisect log

~/bibisect-win32-6.0
$ git bisect good
53cd0ea77358e5ea6f8933846afdfa4192290b10 is the first bad commit
commit 53cd0ea77358e5ea6f8933846afdfa4192290b10
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date:   Sat Jul 29 16:11:21 2017 -0700

    source sha:94c7a401583200cf5982594b1b043ad1a5e3cd38

    source sha:94c7a401583200cf5982594b1b043ad1a5e3cd38

:040000 040000 aeb8bb5ed3559a4d854e68b2667c85b3e1e7c64f
b8f5129dbc48f015bbd7e7f90ff1bd83dd364e62 M      instdir

----

author  Caolán McNamara <caolanm at redhat.com>    2017-07-14 13:22:06 (GMT)
committer       Caolán McNamara <caolanm at redhat.com>    2017-07-14 16:11:03
(GMT)
commit  94c7a401583200cf5982594b1b043ad1a5e3cd38 (patch)
tree    993b6717312394349d547e271b8e2e8811194b12
parent  6b6b81cae861a1e6463360d1b320c0d3e24de111 (diff)
Resolves: tdf#99071 tree view shows odd text widths when > 100 lines
reverts

commit 62ea355b2679073b8ee326df5793231996136da9
Date:   Thu Dec 12 09:55:35 2013 +0100

    fdo#72125: GetTextWidth() can get very expensive.

    Let's just count an approximate width using a cached value when we have too
    many entries.

The expert dialog got fixed by not populating it with all options on load
and instead by incremental disclosure as the users searches/expands it so
this optimization effort isn't needed

in the meantime there was another problem the above papered over with

commit b4bbb5e5d7b31caad2fbcc00382ad27df3c81001
Date:   Sun May 17 22:56:46 2015 +0900

refactor how font, fg. and bg. are applied in widgets/controls

which was fixed (hopefully) in the previous commit

Change-Id: I8383d9cd7a9983a85c7f3acec0281d984c44f9e7
Reviewed-on: https://gerrit.libreoffice.org/39951
Tested-by: Jenkins <ci at libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm at redhat.com>
Tested-by: Caolán McNamara <caolanm at redhat.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20171004/41e9920b/attachment.html>