[Libreoffice-bugs] [Bug 100233] Wrong Windows version reported in the About window in Windows 10

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=100233

--- Comment #18 from Mike Kaganski <mikekaganski at hotmail.com> ---
Yes, that commit guarantees that we will continue to get proper Windows
versions for display, even if program will run on a future Windows version.
Another commit -
https://cgit.freedesktop.org/libreoffice/core/commit/?id=736a4e659cff2ef5f900301d7d288494f9b98178
- adds compatibility sections to our binaries' manifests claiming support of
Win7 through Win10, so this also "fixes" GetVersion* API results, but that
would fail on next Windows version, and is only meant to prevent us running in
compatibility (reduced) mode.

To clarify: Windows versions are not a float that can be rounded: they are a
series of integers, which are simply displayed using dot between them, so no
"rounding" is possible here. The "19" came from Microsoft for unclear reasons:
trying to use its recommended API (IsWindowsVersionOrGreater), we used to try
to find out the highest supported version and subversion numbers by starting at
a high value (30), decrementing by one, and asking that API if that version and
subversion are supported; and it returned true for subversion 19 on version 6
for Win10. See WinSalInstance::getOSVersion() changes in
https://cgit.freedesktop.org/libreoffice/core/commit/?id=0dd2e602e5c1b46e82abc6051677aeaab1d265b8
for old implementation details.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20171005/d68ff755/attachment.html>