[Libreoffice-bugs] [Bug 108458] Label changes for Toolbar use degrade function listing in the Customize dialog--have duplicate entries on the list

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=108458

--- Comment #3 from Yousuf Philips (jay) <philipz85 at hotmail.com> ---
(In reply to Maxim Monastirsky from comment #2)
> 1. "Label" always contains the complete command name, thus suitable for the
> customization dialog (It can also have accelerator & ellipsis which we can
> strip at runtime if needed).

+1 as it focuses on the entry that is always assigned and targeting the menu
bar

> 2. "TooltipLabel" should fallback then to "Label" directly, instead of the
> weird PopupLabel->ContextLabel->Label fallback path.

+1 as tooltip will be descriptive form of Label string

> 3. "ContextLabel" will override "Label" for all kinds of ui elements
> (toolbar/menubar/popupmenu). Typical use case is having a shortened label
> (assuming that if all need a shortened label, probably it will be the same).

Toolbar label will normally need the shorter form, while menubar and popupmenu
normally dont.

> 4. In case not all ui elements want the same label, then those that need the
> long variation will use the original command, and the special (e.g. short)
> variation will be handled using an alias.

Dont really like the idea of separating this.

> 5. "PopupLabel" becomes unused and will be removed.

PopupLabel will always be useful as it can have a different accelerator key
than the menubar or a completely different label, e.g. 'More Options...',
'Close Preview' (.uno:PrintPreview)

> 6. To make it easier to identify aliases, they can just append a context to
> the original command (e.g. ".uno:EditStyle:stylesmenu"), instead of
> inventing new command names each time.

i think aliasing should be done within a <prop> element rather than with a new
node.

So here is my suggestion :D

1. Label - same as maxim's (will normally be either suitable for the toolbar,
menubar, or tooltip label)
2. TooltipLabel - same as maxim's
3. ContextLabel will be used when Label is suitable for toolbar and will be
used for menubar and context menu, else fallback on Label
4. PopupLabel for context menu, when a different accelerator or label is needed
than what is found in ContextLabel or Label
5. ToolbarLabel will be used when Label is suitable for menubar and will be for
the toolbar and notebookbar, else fallback on Label
6. We also need a mechanism to assign any of these entries to another label
without having to type its label again, as this would reduce translation work.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20171027/54afa6f8/attachment-0001.html>