[Libreoffice-bugs] [Bug 112388] Fraction::Fraction(Fraction const&) leaks memory

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=112388

Julien Nabet <serval2412 at yahoo.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |caolanm at redhat.com,
                   |                            |erack at redhat.com

--- Comment #2 from Julien Nabet <serval2412 at yahoo.fr> ---
Caolán/Eike: I took a look at the BT included here and found toolkit, vcl and
sc parts.
   3 libtllo.dylib Fraction::Fraction(Fraction const&)
./tools/source/generic/fract.cxx:60^M
   4 libtllo.dylib Fraction::Fraction(Fraction const&)
./tools/source/generic/fract.cxx:61^M
   5 libtllo.dylib Fraction::operator=(Fraction const&)
./tools/source/generic/fract.cxx:296^M
   6 libvcllo.dylib MapMode::SetScaleY(Fraction const&)
./vcl/source/gdi/mapmod.cxx:127^M
   7 libsclo.dylib ScGridWindow::GetDrawMapMode(bool)
./sc/source/ui/view/gridwin3.cxx:268^M
   8 libsclo.dylib ScTabView::MakeDrawView(TriState)
./sc/source/ui/view/tabview5.cxx:244^M

After adding some debug logs, I compared the number of calls of Fraction ctr
and dtr and indeed, there's less call to dtr.
I tried to find why and noticed o3tl::cow_wrapper< ImplMapMode > ImplType at
frame 6
If there were just a dozen of them, I would take a bt of each to compare but
there are thousands of calls. I also tried to distinguished the 5 ctrs, hoping
to find a specific one called n times ("n" would have been the investigated
diff)
Any thoughts to keep on here?

Besides, frame 8 corresponds to:
244     pGridWin[i]->SetMapMode(pGridWin[i]->GetDrawMapMode());

and searching in SetMapMode, thought this patch for review
https://gerrit.libreoffice.org/#/c/42306/  may also be useful even if not for
the Fraction part indeed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20170914/d6dff030/attachment.html>