[Libreoffice-bugs] [Bug 111967] Vertical text in table formatted incorrectly and crashed after placing cursor

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=111967

--- Comment #15 from Mark Hung <marklh9 at gmail.com> ---
> 
> Yes, I remember now. I was actually setting next to Behdad when he was
> hacking this code for that release and I remember wondering if these changes
> are going to affect the brittle way we (I) position vertical glyphs.
> Unfortunately all the details escape me know and I need to dig both the
> HarfBuzz changes and the related LibreOffice code to have anything
> meaningful :( Actually I think that is why I didn’t update our bundled
> HarfBuzz all that time.

Hi Khaled,

I checked more detail today.

Inside hb-font-private.hh, fallback version of get_glyph_h_origin() and
get_glyph_v_origin() were introduced in 1.3.4. It worked if I replace those
back to non-fallback version in subtract_glyph_h_origin() ,
subtract_glyph_v_origin(), get_glyph_h_origin_with_fallback(),
get_glyph_v_origin_with_fallback(). 

The test might be naive, but guess_v_origin_minus_h_origin() looks suspicious
from my point of view. I don't know how it might related to "how you position
vertical glyphs". I'll try to check that if you have some code pointers.

BTW, 1.5.0 and 1.5.1 don't work too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20170915/db50e644/attachment.html>