[Libreoffice-bugs] [Bug 112532] New: Color picker widget is slow to initialize - does not cache color palette data

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=112532

            Bug ID: 112532
           Summary: Color picker widget is slow to initialize - does not
                    cache color palette data
           Product: LibreOffice
           Version: 6.0.0.0.alpha0+ Master
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: medium
         Component: framework
          Assignee: libreoffice-bugs at lists.freedesktop.org
          Reporter: kelemeng at ubuntu.com

While working on bug#105000 - and sprinkling a few SAL_WARN into
SvxUnoConvertResourceStringBuiltIn() of svx/source/unodraw/unoprov.cxx [1] - I
noticed that the color picker widget runs this color palette initalization
method every time it is instantiated. 
This is problematic if there is a window with more than one of this widget,
like Options - LibreOffice - Application colors or Options - Writer - Changes,
causing slow reaction from the window and a spike in CPU usage as well.

For each widget instance it seems like the current color palette is being read
and processed, but this seems to be unnecessary a bit and might be cacheable
for better performance. 

[1]
https://opengrok.libreoffice.org/xref/core/svx/source/unodraw/unoprov.cxx#1588

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20170920/390b5409/attachment-0001.html>