[Libreoffice-bugs] [Bug 116999] Libreoffice command line interface is not opening cgm files

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=116999

Caolán McNamara <caolanm at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|libreoffice-bugs at lists.free |caolanm at redhat.com
                   |desktop.org                 |

--- Comment #7 from Caolán McNamara <caolanm at redhat.com> ---
I think the len check is actually good. Its that we're using null terminated
strings here and expect that we can add a zero at the end, which is possible in
this specific case, but not in the general case if that field has filled with a
number > the buffer size. So this has headed off disaster in the general case.

For the specific case I think what we can do is to rework this to not need to
add a null terminator and just build an OUString directly from the known length

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20180416/354a8d75/attachment-0001.html>