[Libreoffice-bugs] [Bug 117058] New: Simplify calls to Menu::CheckItem

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=117058

            Bug ID: 117058
           Summary: Simplify calls to Menu::CheckItem
           Product: LibreOffice
           Version: 6.0.0.0.alpha0+
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: medium
         Component: LibreOffice
          Assignee: libreoffice-bugs at lists.freedesktop.org
          Reporter: muhammet.kara at pardus.org.tr

If you wanted to check a menu item by its name, you had to do it like this:

pGearMenu->CheckItem( pGearMenu->GetItemId("gear_iconOnly") );

Now we can do it just like this:

pGearMenu->CheckItem( "gear_iconOnly" );


There are still some instances of the old-style calls that needs to be changed.
You can search with "git grep CheckItem" for such instances, and change them to
the new style. Just make sure it is a call to the CheckItem method of the Menu
class (or one of its sub-classes), but not a call to CheckItem method of an
unrelated class.

Example commit:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=66ed9797ba8f61994a187dfcc189f375dcd0cdcc

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20180417/80f2b5ca/attachment.html>