[Libreoffice-bugs] [Bug 117063] Double-click does not expand/ collaps the options in the navigator

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=117063

--- Comment #2 from Jim Raykowski <raykowj at gmail.com> ---
Hi Xisco,

The intent of tdf#36308 was to do just this. It requires that the tree node
icon to be clicked to expand/collapse. For Headings navigation this has been
considered an improvement. I agree that this is a regression of behavior for
the other navigation elements. 

Here is a patch that provides for double click to expand/contract for
navigation elements other than content type Headings:

https://gerrit.libreoffice.org/#/c/53074/


This has required a change to a recent patch 

commit 1b9af08481b8f7f4bd15a30508606dff56b8e74f
Author: Jan Holesovsky <kendy at collabora.com>, Tue Mar 13 12:39:11 2018 +0100 (5
weeks ago)
Committer: Jan Holesovsky <kendy at collabora.com>, Tue Mar 13 16:28:40 2018 +0100
(5 weeks ago)
Follows: libreoffice-6-0-branch-point
Branches: <Expand>

tdf#116334: Actually when there is no handler, we have to return 'true'.

Also use the return value of the link's Call() [as the
SvTreeListBox::ExpandingHdl()
is doing], the appropriate callbacks seem to return the expected 'false' in
the cases I've reviewed...

Change-Id: I0cdd63e8ec4c794839070b914150e0b32f743359
Reviewed-on: https://gerrit.libreoffice.org/51211
Tested-by: Jenkins <ci at libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy at collabora.com>

to what the patched code was two patches prior 

treelistbox.cxx:428 
bool SvTreeListBox::DoubleClickHdl()
{
    aDoubleClickHdl.Call( this );
    return true;
}

This is because if SvTreeListBox::DoubleClickHdl() does not return true

svimplbox.cxx:2024 
if( pView->DoubleClickHdl() )

will not be entered and 

svimplebox.cxx:2041
if( bSubLstOpDblClick )

can not be checked to decide if the element is one where it's sublist should be
expanded/collapsed on doubleclick.

We better check with Jan on this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20180418/075c4f69/attachment-0001.html>