[Libreoffice-bugs] [Bug 117994] Font size is too large in attached DOC in Word after roundtrip

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=117994

--- Comment #4 from Justin L <jluth at mail.com> ---
Created attachment 143951
  --> https://bugs.documentfoundation.org/attachment.cgi?id=143951&action=edit
tdf117994_fixAttempt.patch - a keep-changing-things-until-somehow-it-all-works
patch

So, Luke's idea that after the CR, you "force" the CR to be included in the
previous character attributes seems to be right. Before, I think large.doc
"just happened" to look OK, because the following sentence used the same
formatting.

The reason Luke's patch worked only with his example is because he was working
with an IsEmptySprm, which just got extended like he wanted. In this bug's
case, there is an existing character format SPRM which triggers a new, empty,
character format being created just for the CR.

So, my patch changes the logic of "force", so that it doesn't just ensure that
a mark is made, but that it specifically extends the existing character format
to include this position. (I hope that still works as intended for the other
existing use of "force" in redlining.)

There really are two problems in this bug report.  The one is import related -
since LO doesn't show the LARGE spacing that Word does. And unfortunately, bug
102334's unit test likely hits that same problem because ww8export complains
about hidden text showing up after this patch, but when opening the file in
Word, the text is still hidden.

So, first things first I guess, and that is to investigate the import bug. But
anyone is welcome to check this export patch and tell me what regressions it
will cause :-).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20180803/399a4cff/attachment.html>