[Libreoffice-bugs] [Bug 117185] Crash when closing the document after a specific undo redo operation (Paste) due to inserted fly anchored at end of last paragraph in body

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=117185

Michael Stahl <michael.stahl at cib.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michael.stahl at cib.de
           See Also|                            |https://bugs.documentfounda
                   |                            |tion.org/show_bug.cgi?id=10
                   |                            |7975,
                   |                            |https://bz.apache.org/ooo/s
                   |                            |how_bug.cgi?id=97570
            Summary|Crash when closing the      |Crash when closing the
                   |document after a specific   |document after a specific
                   |undo redo operation         |undo redo operation (Paste)
                   |(ucrtbase)                  |due to inserted fly
                   |                            |anchored at end of last
                   |                            |paragraph in body

--- Comment #7 from Michael Stahl <michael.stahl at cib.de> ---
the problem is that the last Paste action inserts a fly that is anchored
AT_CHAR at the end of the last paragraph in the document, but the
SwUndoInserts::UndoImpl does not remove this fly, which causes the indexes that
are stored in the Undo actions to point to the wrong nodes due to the added
fly-section at the start of the SwNodes.

this situation was previously fixed by:

commit 2903d85d6197829633d7f96c95cd55821c2c20ff

    fix deleting an image anchored to last paragraph in document

    It only compared nodes instead of SwPositions, thus refusing to delete
    anything anchored at the last content node. Also, select-all makes
    rEnd point to the last content node, after its content. So if
    an anchor-to-char image is anchored at the end of the paragraph,
    it points to this place, too, so that must be checked.

but unfortunately this commit introduced a different problem (see bug 107975)
and re-introduced OOo issue 97570, hence i've reverted it in commit
14d2255cbd254dea6e87a04f747e7d6d3d54ceb9 due to lack of time, see also
https://bugs.documentfoundation.org/show_bug.cgi?id=107975#c9

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20180830/f29f07f5/attachment.html>