[Libreoffice-bugs] [Bug 119615] CRASH - closing table causes crash using mysql ODB with native connector connected to a mysql instance

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=119615

--- Comment #11 from Noel Grandin <noelgrandin at gmail.com> ---
(In reply to Julien Nabet from comment #10)
> If it's just reverting m_aFields part of the patch, I'll be able to do this
> when I come back to home after my day time job.

Yup, that was what I meant.

> 
> However, it seems we may have a memory leak.
> According to https://mariadb.com/kb/en/library/mysql_free_result/, a call to
> mysql_fetch_row implies a call to mysql_free_result and I'm not sure
> "OPreparedResultSet::close()" method was called in the bt.
> Should a call to this method in destructor could make it? (and we could keep
> unique_ptr in the same time)?

Probably close() should call mysql_free_result and then set the pointer to
null.
The destructor should check the pointer and only call mysql_free_result if the
pointer is non-null.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20180831/963365f4/attachment.html>