[Libreoffice-bugs] [Bug 121838] Firebird: Mirgration: Certain ODB crashes application during Migration Assistant execution

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=121838

Julien Nabet <serval2412 at yahoo.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lionel at mamane.lu

--- Comment #7 from Julien Nabet <serval2412 at yahoo.fr> ---
Trying to debug, I get in
connectivity/source/drivers/firebird/PreparedStatement.cxx:841
during test, nSize = -1 because short type seems to small.

diff --git a/connectivity/source/drivers/firebird/PreparedStatement.cxx
b/connectivity/source/drivers/firebird/PreparedStatement.cxx
index e0d120d0cfec..57cb70b7f178 100644
--- a/connectivity/source/drivers/firebird/PreparedStatement.cxx
+++ b/connectivity/source/drivers/firebird/PreparedStatement.cxx
@@ -847,7 +847,7 @@ void SAL_CALL OPreparedStatement::setBytes(sal_Int32
nParameterIndex,
             {
                 xBytesCopy.realloc( nMaxSize );
             }
-            const short nSize = xBytesCopy.getLength();
+            const sal_Int32 nSize = xBytesCopy.getLength();
             // 8000 corresponds to value from lcl_addDefaultParameters
             // in dbaccess/source/filter/hsqldb/createparser.cxx
             if (nSize > 8000)

prevents from having the crash.

Of course, it doesn't prevent from having the error message:
warn:connectivity.firebird:1966:1966:connectivity/source/drivers/firebird/Util.cxx:55:
firebird_sdbc error:
*Dynamic SQL Error
*SQL error code = -104
*Token unknown - line 1, column 84
*\
caused by
'isc_dsql_prepare'

warn:connectivity.firebird:1966:1966:connectivity/source/drivers/firebird/Util.cxx:55:
firebird_sdbc error:
*Dynamic SQL Error
*SQL error code = -104
*Name longer than database column size
caused by
'isc_dsql_prepare'

Lionel/Tamas: are you ok with the proposed patch above?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20181220/62a1feeb/attachment.html>