[Libreoffice-bugs] [Bug 115275] Tabbed/Notebookbar's Shapes Box title is garbage

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=115275

--- Comment #10 from Maxim Monastirsky <momonasmon at gmail.com> ---
(In reply to baffclan from comment #7)
> However "Table" pulldown box has title.
> I can not understand this difference...
I don't think that difference is intentional. It just that the graphic grip
concept which we use for the shapes popup is inherited from OOo, thus predates
the text based title that we use for other popups like for color or table,
which at first introduced in Go-oo and later imported into LO.

(In reply to Heiko Tietze from comment #8)
> Your are right, the user must not get confused by different controls used
> for the same workflow. The issue is tracked in bug 87239.
That bug deals with several different kinds of inconsistencies. If there's an
agreement here that the shapes popup should be switched to a text title, I
would suggest to reopen this bug, and set it as an enhancement to do the
switch.

The code change needed in this case is trivial, here are code pointers:

The popup is created in ToolBarWrapper::initialize, in case the bPopupMode
variable is true. The title can be retrieved using the
css::ui::theWindowStateConfiguration singleton. The only thing needed is to
retrieve the title, and set it to the popup. But be aware that the resource URL
might be empty, so the code should be surrounded with a try-except block etc.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20180129/37b62baa/attachment.html>