[Libreoffice-bugs] [Bug 118731] Dialogs like Format page/ format header open with a annoying delay since 6.2

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=118731

--- Comment #6 from Armin Le Grand (CIB) <Armin.Le.Grand at me.com> ---
Using VerySleepy between Breakpoints:

Statistics for lo-6-1:

Filename: C:\lo\work06_lo-6-1\instdir\program\soffice.bin
Duration: 20.469000
Date: Wed Jul 18 15:10:36 2018
Samples: 13560

Statistics for lo-6-2 (master):

Duration: 34.234000
Date: Wed Jul 18 15:17:02 2018
Samples: 23136

Looking at
SwDocShell::Edit        2.05s   20.46s  0.67%   6.67%

I can follow both paths down to
vcl::Window::get_ungrouped_preferred_size       0.00s   15.59s  0.00%   5.08%

with lo-6-2 using ChildCalls:
VclContainer::GetOptimalSize    44.22s  41.00%  vcllo  
c:\lo\work01\vcl\source\window\layout.cxx       45      0x51e3c9ca
SystemWindow::GetOptimalSize    29.05s  26.93%  vcllo  
c:\lo\work01\vcl\source\window\syswin.cxx       1065    0x51ec570c
TabControl::GetOptimalSize      29.00s  26.89%  vcllo  
c:\lo\work01\vcl\source\control\tabctrl.cxx     2163    0x51fb460a
TabPage::GetOptimalSize 2.27s   2.11%   vcllo  
c:\lo\work01\vcl\source\window\tabpage.cxx      187     0x51ecae8e
FixedText::GetOptimalSize       1.55s   1.44%   vcllo  
c:\lo\work01\vcl\source\control\fixed.cxx       351     0x51f7b225
ImplBorderWindow::GetOptimalSize        0.65s   0.61%   vcllo  
c:\lo\work01\vcl\source\window\brdwin.cxx       2063    0x51d7535e
PushButton::GetOptimalSize      0.47s   0.44%   vcllo  
c:\lo\work01\vcl\source\control\button.cxx      1679    0x51f39ab3
CheckBox::GetOptimalSize        0.22s   0.21%   vcllo  
c:\lo\work01\vcl\source\control\button.cxx      3728    0x51f39a95
SpinField::GetOptimalSize       0.22s   0.20%   vcllo  
c:\lo\work01\vcl\source\control\spinfld.cxx     928     0x51fab21b
RadioButton::GetOptimalSize     0.14s   0.13%   vcllo  
c:\lo\work01\vcl\source\control\button.cxx      2909    0x51f39ad3
Edit::GetOptimalSize    0.05s   0.05%   vcllo  
c:\lo\work01\vcl\source\control\edit.cxx        2747    0x51f5b6db

and lo-6-1 using ChildCalls:
VclContainer::GetOptimalSize    32.16s  47.89%  vcllo  
c:\lo\work06_lo-6-1\vcl\source\window\layout.cxx        45      0x51adec5a
SystemWindow::GetOptimalSize    14.36s  21.38%  vcllo  
c:\lo\work06_lo-6-1\vcl\source\window\syswin.cxx        1065    0x51b6df7c
TabControl::GetOptimalSize      14.30s  21.29%  vcllo  
c:\lo\work06_lo-6-1\vcl\source\control\tabctrl.cxx      2163    0x51c66c4a
TabPage::GetOptimalSize 2.53s   3.76%   vcllo  
c:\lo\work06_lo-6-1\vcl\source\window\tabpage.cxx       187     0x51b7352e
FixedText::GetOptimalSize       1.84s   2.74%   vcllo  
c:\lo\work06_lo-6-1\vcl\source\control\fixed.cxx        351     0x51c298f1
ImplBorderWindow::GetOptimalSize        0.71s   1.06%   vcllo  
c:\lo\work06_lo-6-1\vcl\source\window\brdwin.cxx        2063    0x51a082ae
PushButton::GetOptimalSize      0.52s   0.78%   vcllo  
c:\lo\work06_lo-6-1\vcl\source\control\button.cxx       1680    0x51be6333
SpinField::GetOptimalSize       0.31s   0.46%   vcllo  
c:\lo\work06_lo-6-1\vcl\source\control\spinfld.cxx      928     0x51c5c91b
CheckBox::GetOptimalSize        0.30s   0.44%   vcllo  
c:\lo\work06_lo-6-1\vcl\source\control\button.cxx       3735    0x51be6315
RadioButton::GetOptimalSize     0.11s   0.16%   vcllo  
c:\lo\work06_lo-6-1\vcl\source\control\button.cxx       2910    0x51be6353
Edit::GetOptimalSize    0.03s   0.04%   vcllo  
c:\lo\work06_lo-6-1\vcl\source\control\edit.cxx 2749    0x51c0a61b

This shows that most time - and more time - is spent in that area.
There is *no* DrawingLayer stuff involved, FYI.
Adding Caolan to CC, he may know why that layouting stuff got slower in master
compared to lo-6-1...

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20180718/5036ec89/attachment-0001.html>