[Libreoffice-bugs] [Bug 118829] FILEOPEN ODT setting only one of MARGIN-TOP/MARGIN-BOTTOM uses the settings of the style:default-style instead of the assigned style for the other

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=118829

László Németh <nemeth at numbertext.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO
                 CC|                            |nemeth at numbertext.org

--- Comment #3 from László Németh <nemeth at numbertext.org> ---
(In reply to Justin L from comment #1)
> Bibisect-43all suggests inherited from OOo.
> 
> Assuming this gets fixed, the commit for docx in bug 118521 can be reverted
> (since it starts hard-coding paragraph properties where they didn't exist
> before).

It seems, LibreOffice UI does the same. It's possible that not just because of
performance, but it's better to handle related properties in a group for
consistent UI. For example, we want to set all margins with direct paragraph
formatting, but we cannot, if the value is the same as in the parent-style.
LibreOffice uses this grouped approach on the other properties, too, and
somewhere doesn't not (and there we need to play the following: to modify the
attribute to a different value, and reset it to the default for overwriting the
inherited value with the same, but direct formatted value for to get the
required template settings).

Also this is related to the standard, too. It seems, we need to check CSS2
first, according to the OpenDocument standard:

https://www.w3.org/TR/2001/REC-xsl-20011015/slice7.html#margin-top

CSS has got some grouping for these properties, but it is more flexible, than
OpenOffice.org style handling, and maybe it's different in this case.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20180718/d3414490/attachment.html>