[Libreoffice-bugs] [Bug 118662] FILESAVE - Time to save a 500Kb xlsx file has grown and causes a dump (see comment 7)

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=118662

Armin Le Grand (CIB) <Armin.Le.Grand at me.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|libreoffice-bugs at lists.free |Armin.Le.Grand at me.com
                   |desktop.org                 |

--- Comment #23 from Armin Le Grand (CIB) <Armin.Le.Grand at me.com> ---
I had added a huge comment in XclObjComment already when I removed the cloning
of the SdrCaptionObject, see there (will delete this in the fix). It defines
why this cannot be reverted - it leads to errors itself.
Another reason to not revert this is that SdrObjects should be inserted to a
SdrPage/SdrGroup, else functionality is not guaranteed.
To fix this:
- Add an exclusive boolean flag to SdrCaptionObj, only accessible from
XclObjComment, that will be used to suppress graphic creation in
SvxShape::GetBitmap
- SvxShape::GetBitmap is a biiig time killer as we saw, mainly because always a
full E3dView is constructed and used - ARGH! There are more elegant methods to
create graphics nowadays. Will refresh that code. Metafile target can use
SingleObjectPainter, Bitamp target can use convertPrimitive2DSequenceToBitmapEx
directly.
- SdrObject::bInserted/IsInserted()/SetInserted can be simplified. No need for
a local bool, change SetInserted to a state change (InsertedStateChange()),
IsInserted() will be directly depend on being a member in a SdrObjList.

With this in place we may just let the SdrCaptionObj's create the graphics, it
will be faster. But better not, this may increase file size and these are
really not needed (at least nut until now). As I have seen most of these are
PostIt objects anyways.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20180719/cc080ead/attachment-0001.html>