[Libreoffice-bugs] [Bug 109190] Auto Optimal View gives jarring experience

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=109190

Justin L <jluth at mail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|libreoffice-bugs at lists.free |jluth at mail.com
                   |desktop.org                 |

--- Comment #8 from Justin L <jluth at mail.com> ---
(In reply to Justin L from comment #6)
> https://cgit.freedesktop.org/libreoffice/core/commit/
> ?id=23391fdb5cffb62006415ad1f4c96b6ed5d50cf8
There is a bug in the conversion from 
while(rRect.Bottom() > aNewPos.Y() + aVisAreaSize.Height())
to
const long distBottom(rRect.Bottom() - aNewPos.Y() - aVisAreaSize.Height());

While the bottom of the object is lower on the page than the visual Top
position plus the height of the screen, move the screen down by the size of the
object.  The loop could first be finished when the shape bottom is exactly at
the bottom of the screen: rRect.Bottom() = aNewPos.Y() + screen Height.
or rRect.Bottom() - (aNewPos.Y() + aVisAreaSize.Height()) = 0
or rRect.Bottom() - aNewPos.Y() - aVisAreaSize.Height() = 0

 https://gerrit.libreoffice.org/55156

Note that this is not exactly perfect for the described case because the screen
will move better, but the cursor will not be in the place where the use
clicked. It will be in the same place on the screen, but since the contents
moved, it won't be on the clicked contents.  (That problem existed already
before the regression.)

However, this DOES fix the following jumping problem. Find Sept 30 "Holidays"
and position the screen so that you only see "Holi". Arrow right through
Holidays. Now it will just scroll slightly, instead of jumping to the opposite
side of the screen.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20180601/20047135/attachment.html>