[Libreoffice-bugs] [Bug 117335] GIF images fail to display in Impress

bugzilla-daemon at bugs.documentfoundation.org bugzilla-daemon at bugs.documentfoundation.org
Tue Jun 26 14:54:37 UTC 2018


https://bugs.documentfoundation.org/show_bug.cgi?id=117335

--- Comment #8 from Armin Le Grand (CIB) <Armin.Le.Grand at me.com> ---
No idea what to do when it's only on the Mac- I do not have one. The code
changed as follows:

-            const BitmapColor& rColor = mrPalette[ (pData[mnX >> 3 ] >> ( 7 -
( mnX & 7 ) )) & 1];
+            // Caution(!) rPalette.GetEntryCount() may be != (depth^^2)-1 (!)
+            const sal_uInt8 nIndex( (pData[mnX >> 3 ] >> ( 7 - ( mnX & 7 ) ))
& 1);

Checking the index acces *is* needed (there are palettes with less than 0xff
colors - I thought about fixing this first). Maybe a Mac-Dev could tr to use
sal_uInt16 instead of sal_uInt8 - something strange with the Mac-Compiler seems
to be happening here (due to working on all other systems...).
Sprry, I have (still) no Mac.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20180626/fc6340aa/attachment.html>


More information about the Libreoffice-bugs mailing list