[Libreoffice-bugs] [Bug 115507] Style names become invisible if the default style used white color

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=115507

--- Comment #7 from Heiko Tietze <tietze.heiko at gmail.com> ---
Created attachment 140290
  --> https://bugs.documentfoundation.org/attachment.cgi?id=140290&action=edit
Selection issue

Tried to solve the issue myself, and it's easy to change the background
depending on the color at templdlg.cxx with 

void StyleLBoxString::Paint() 
...
rRenderContext.SetDrawMode( DrawModeFlags::BlackFill );

Though I couldn't figure out how to access the font color of the current style,
perhaps something like

SfxItemSet& pItemSet = pStyleSheet->GetItemSet();
SfxPoolItem& pItem = pItemSet.GetItem( SID_ATTR_CHAR_COLOR_EXT );

But actually I tend to agree with m.a.riosv to keep it full WYSIWYG (comment 4)
since using a white font on white background (or vice versa) has been done
intentionally by the user. The alternative is to highlight the selection like
for default styles (such as Test 1 with automatic and none colors). 

In case of automatic font color it's adjusted in the sidebar too but apparently
with a different formula as shown in the attachment. Test 2 in the document is
black while it's contrast seems to be calculated as enough for white in the
sidebar.

To summarize: My suggestion would be to always highlight the selection in the
system color.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20180302/a5a0d9b6/attachment.html>