[Libreoffice-bugs] [Bug 106746] copy/pasting revisions copy deleted words

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=106746

Aron Budea <baron at caesar.elte.hu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|medium                      |high
             Blocks|                            |83946
           Severity|minor                       |normal

--- Comment #13 from Aron Budea <baron at caesar.elte.hu> ---
The problem is with the following piece of change:
https://cgit.freedesktop.org/libreoffice/core/diff/sw/source/core/doc/DocumentContentOperationsManager.cxx?id=db17d3c17c40d6b0e92392cf3c6e343d1d17b771

The pointer in pDelPam actually needs to be preserved here:
pDelPam.reset(new SwPaM( *pCpyStt, pDelPam.get() ));

The following change fixes the behavior by releasing the smart pointer:
pDelPam.reset(new SwPaM( *pCpyStt, pDelPam.release() ));

Is the code otherwise correct? I'm surprised working with an invalid pointer
didn't cause a serious issue.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=83946
[Bug 83946] [META] Tracking changes issues
-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20180307/92017b18/attachment.html>