[Libreoffice-bugs] [Bug 116334] Double-click does not expand option tree

bugzilla-daemon at bugs.documentfoundation.org bugzilla-daemon at bugs.documentfoundation.org
Tue Mar 13 10:33:15 UTC 2018


https://bugs.documentfoundation.org/show_bug.cgi?id=116334

--- Comment #5 from Jim Raykowski <raykowj at gmail.com> ---
(In reply to Jim Raykowski from comment #3)

> 
> What I can see is happening to cause this now is that double clicks are
> being seen as single clicks here [1] causing the code that expands/collapses
> on double click to be skipped over.
>  
> [1]
> https://opengrok.libreoffice.org/xref/core/svtools/source/contnr/svimpbox.
> cxx#2020

So this isn't due to the double clicks being seen as single clicks but a few
lines of code down the DoubleClickHdl() has been recently changed to return
false.

commit 7651e57573952758032ceb88f16e2dbbb6cc4e18
Author: Jan Holesovsky <kendy at collabora.com>, Thu Mar 1 12:13:53 2018 +0100 (12
days ago)
Committer: Jan Holesovsky <kendy at collabora.com>, Thu Mar 1 15:41:13 2018 +0100
(12 days ago)
Follows: libreoffice-6-0-branch-point
Branches: <Expand>

tdf#115950: Indicate that the dialog was already destroyed.

The DoubleClickHdl()'s return value does not mean "was handled", but actually
"is there anything more to be done"; so if we actually destroy the dialog in
the aDoubleClickHdl.Call(this), we have to return 'false'.

Change-Id: I7c510e8341eb5f74703b4266f86cb1e840a2b1fd
Reviewed-on: https://gerrit.libreoffice.org/50261
Tested-by: Jenkins <ci at libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy at collabora.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20180313/3746b474/attachment.html>


More information about the Libreoffice-bugs mailing list