[Libreoffice-bugs] [Bug 116640] CRASH/Assertion when undoing columns

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=116640

Buovjaga <todventtu at suomi24.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|bibisectRequest             |bibisected, bisected
                 CC|                            |mst.lo at arcor.de

--- Comment #7 from Buovjaga <todventtu at suomi24.fi> ---
Ok, this was "a bit" convoluted to bisect. Using the original steps in bibisect
repo 5.1, I got this as the bad commit:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=5adc8ee343e5c32d30095bc4005b7b022016b745

commit  5adc8ee343e5c32d30095bc4005b7b022016b745 (patch)
tree    8148a23a2b68e26b43a308c71fac3feb43319814
parent  4ff0032528d7aebb0de5cf045a39972a2769029f (diff)
sw: fix newly created document being modified
After the document is created, an event is dispatched on the main loop
that calls SfxPickList::Notify(), which modifies document properties.

It tries to prevent setting the document to modified by calling
SfxObjectShell::EnableSetModified(false), but Writer cunningly outwits
it by simply having its own independent(?) modified flag that is set
unconditionally in DocumentStatisticsManager::DocInfoChgd().

Let's assume that if the modified flag shouldn't be modified in
SfxObjectShell, it shouldn't be modified in DocumentStatisticsManager.

Somehow in 4.4 and 4.3 the same thing was going on, but it didn't result
in a visibly enabled Save icon in the UI, but with 5.0 it does - cannot
easily bisect why that changed due to tdf#91383.

Change-Id: Id30fd831eb29910c9fb44ed3031bf8da23586bea

Adding mst to CC.

However, even in 5.0 repo I could reproduce a crash, if after step 5, I did
redo (Ctrl-Y), input text again into the section, undo twice.
I continued testing and discovered this crash is already in 4.3.

So I don't know - maybe mst's commit just made this crash earlier??

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20180327/b090adad/attachment-0001.html>