[Libreoffice-bugs] [Bug 117805] DOCX: section in frame removes header in docx export

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=117805

Xisco Faulí <xiscofauli at libreoffice.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |bibisected, bisected,
                   |                            |regression
                 CC|                            |vmiklos at collabora.co.uk,
                   |                            |xiscofauli at libreoffice.org
            Version|6.1.0.0.beta1+              |4.4 all versions

--- Comment #7 from Xisco Faulí <xiscofauli at libreoffice.org> ---
Regression introduced by:

author  Miklos Vajna <vmiklos at collabora.co.uk>  2014-08-18 15:14:31 +0200
committer       Miklos Vajna <vmiklos at collabora.co.uk>  2014-08-18 15:51:16
+0200
commit  f6b681a1360d953ec7a9f2f4f843c0d76d478c2a (patch)
tree    0a79b7d29081cf342643e3492bd3fd42ee52f23c
parent  aa1d3d5eeaa795f6b913bbcd55bd31dc6802a4fe (diff)
DOCX export: don't forget to close SDT elements inside the TextBoxes of shapes
A usual problem with SDT is that in case it should end after the last
paragrah of a container, there is no "next" paragraph that could have
the relevant "EndSdtBefore" property. This is usually handled by closing
the SDT tag before the container is closed.

The problem here was that DocxAttributeOutput::WriteSdtBlock() did not
notify DocxSdrExport about opening the SDT, as it thought there is no
draw export in progress. This is because in case of "shape with a
TextBox", the common writeDMLAndVMLDrawing() method is not called,
instead the separate writeDMLTextFrame() and writeVMLTextFrame() methods
are invoked.

Fix the problem by adjusting these methods to writeDMLAndVMLDrawing(),
so that they also set m_bDMLAndVMLDrawingOpen to true during the TextBox
export.

Bisected with: bibisect-44max

Adding Cc: to Miklos Vajna

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20180531/f0519355/attachment.html>