[Libreoffice-bugs] [Bug 120175] Breeze Dark icon theme is not detected as the preferred theme

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=120175

agrambot at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |106228

--- Comment #2 from agrambot at gmail.com ---
(In reply to V Stuart Foote from comment #1)
> OK, so "BREEZE_DARK_ID" is set [1] to "breeze_dark" with the underscore. If
> it benefits the KDE 5 Plasma DE users, should be a 1 character change, why
> not? 

Is the usage of underscores in the theme ID because of [1]?

> But then SIFR_DARK_ID also gets the underscore with our naming, as does the
> new KARASA_JAGA_ID theme. Any benefit to also change those for consistency
> of matching external DE when calling IconThemeSelector() going forward?

I don't know about SIFR, but it looks like Karasa Jaga suffers from the same
issue as Breeze Dark, because the upstream Karasa Jaga theme is named
"Karasa-Jaga" [2].

=-ref=

[1]
https://opengrok.libreoffice.org/xref/core/icon-themes/README#23-26

[2]
https://github.com/rizmut/karasa-jaga-icon-theme/blob/72054b010a21d46a261d3a1599d0ee4689f41e46/install-karasa-jaga.sh#L25


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=106228
[Bug 106228] [META] Icon theme issues
-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20180929/0c665c58/attachment-0001.html>