[Libreoffice-bugs] [Bug 124553] New: Add adjustX method to B2DPoint

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=124553

            Bug ID: 124553
           Summary: Add adjustX method to B2DPoint
           Product: LibreOffice
           Version: unspecified
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: medium
         Component: LibreOffice
          Assignee: libreoffice-bugs at lists.freedesktop.org
          Reporter: alexanderfarrow at tutanota.com

Description:
Recently I have been looking into resolving
https://bugs.documentfoundation.org/show_bug.cgi?id=103322

This involves changing the types of variables from tools::Point to
basegfx::B2DPoint.

tools::Point has a method called AdjustX(long nHorzMove), which adds nHorzMove
to x.

basegfx::B2DPoint does not have such a method. So calls to AdjustX(nHorzMove)
are being replaced by something like setX(getX() + nHorzMove).

It works fine of course but I think adjustX looks cleaner and it feels like a
step backwards when moving from tools::Point to basegfx::B2DPoint. 

A quick OpenGrok search for AdjustX reveals it is used frequently in the
codebase, so it makes sense to add it to B2DPoint.

If it is agreed that we should add such a method I would like to try to
implement it.


Actual Results:
basegfx::B2DPoint does not have a method similar to tools::Point AdjustX
method. 

Expected Results:
basegfx::B2DPoint has a method like tools::Point AdjustX.


Reproducible: Always


User Profile Reset: No



Additional Info:

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20190404/240ac2d7/attachment-0001.html>