[Libreoffice-bugs] [Bug 124935] FILE OPEN: Formatting of spreadsheet broken: cells get wrong style applied

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=124935

Aron Budea <baron at caesar.elte.hu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
           See Also|                            |https://bugs.documentfounda
                   |                            |tion.org/show_bug.cgi?id=81
                   |                            |765
         Resolution|---                         |WORKSFORME
                 CC|                            |baron at caesar.elte.hu

--- Comment #2 from Aron Budea <baron at caesar.elte.hu> ---
Bibisected it to the following commit. It also doesn't occur anymore in a build
from today, so I assume the fix mentioned in bug 81765 comment 24 fixed it.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=003d11f410b7e515981b3efbd65d936d94d87121
author          Noel Grandin <noel.grandin at collabora.co.uk>     2019-04-20
08:32:33 +0200
committer       Noel Grandin <noel.grandin at collabora.co.uk>     2019-04-20
18:18:20 +0200

"tdf#81765 slow loading of .ods with >1000 of conditional formats"

The likely fixing commit (needs verification if you want to be sure):
https://cgit.freedesktop.org/libreoffice/core/commit/?id=1e3d0a57689006cd7244481958025177c01e4d09
author          Noel Grandin <noel.grandin at collabora.co.uk>     2019-04-23
11:23:36 +0200
committer       Noel Grandin <noel.grandin at collabora.co.uk>     2019-04-23
19:56:53 +0200

"fix bad comparison in StrCmp/StrLess

comment from Miklos:
> Won't this do a comparison of two null-terminated strings, while
> the strings here are utf16, i.e. abc is a\0b\0c\0? That would mean
> in practice you compare the first char only.

introduced in commit 003d11f410b7e515981b3efbd65d936d94d87121"

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20190424/13da4a84/attachment-0001.html>