[Libreoffice-bugs] [Bug 126673] Calc: Auto-fit column and auto-fit row don't work with line break

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=126673

Oliver Brinzing <oliver.brinzing at gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|bibisectRequest             |bibisected, bisected
                 CC|                            |noelgrandin at gmail.com

--- Comment #4 from Oliver Brinzing <oliver.brinzing at gmx.de> ---
seems to have started with:

https://gerrit.libreoffice.org/plugins/gitiles/core/+/c47d0174f2c6c3ebcb3b33276d0277e7aceac330

commit  c47d0174f2c6c3ebcb3b33276d0277e7aceac330        [log]
author  Noel Grandin <noel.grandin at collabora.co.uk>     
Mon Jun 24 11:41:37 2019 +0200
committer Noel Grandin <noel.grandin at collabora.co.uk>   
Tue Jun 25 08:28:49 2019 +0200
tree    8b616687715719ea44b64b3638f68ea024802b90
parent  52800731baf9fcb88e54d60de5585640c8f97f7b [diff]

tdf#94677 Calc is slow opening large CSV, avoid reset SetUpdateMode

Avoid resetting SetUpdateMode in CreateFieldEditEngine while calculating
row height.

This takes the time from 1m25 to 49s for me.

$ git bisect good
2a2aa8404cb678e7ff4294f1acf4ab58290e0b42 is the first bad commit
commit 2a2aa8404cb678e7ff4294f1acf4ab58290e0b42
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date:   Mon Jun 24 23:37:15 2019 -0700

    source sha:c47d0174f2c6c3ebcb3b33276d0277e7aceac330

    source sha:c47d0174f2c6c3ebcb3b33276d0277e7aceac330

:040000 040000 3358008bb02a684164c516287d8d823559f170fb
cfec6f217b6df3929edd46162c192e3f73de2fda M      instdir

/cygdrive/d/sources/bibisect/bibisect-win64-6.4
$ git bisect log
# bad: [b5aeadaf0c99ddd26f240c77db13dfbaf3f0d2cb] source
sha:6eefac3b3744f806b0a35afbd0d9669d840118f4
# good: [8d1eaf05d47fd1c56ddecbe57a9a7c8289ede7f4] source
sha:c98b1f1cd43b3e109bcaf6324ef2d1f449b34099
git bisect start 'master' 'oldest'
# bad: [a4c1d341edcbf697f2cacdb9857549c355a5d221] source
sha:68cd8a97510ccfccb98516539ddb4affc94d46fa
git bisect bad a4c1d341edcbf697f2cacdb9857549c355a5d221
# good: [67be8776331efcaabd433b3ed6ff6b58c56413b2] source
sha:70accc2904edb5c4aa9b5acb7ff2889a77717b75
git bisect good 67be8776331efcaabd433b3ed6ff6b58c56413b2
# bad: [570444f9ad28801a4e801c79543473de1fadc875] source
sha:36defda96fc62cef1e1ffb725f6768d54b0d9cd0
git bisect bad 570444f9ad28801a4e801c79543473de1fadc875
# good: [40674cdf367c1dead50b6478ea3b8fac6500688a] source
sha:fa664e9d30ca9e69af8b5b2c1f3e7739b55f30bb
git bisect good 40674cdf367c1dead50b6478ea3b8fac6500688a
# good: [2a2b0885664e318fe8162765b7286f1a6e9eb059] source
sha:a53768abccfa81d4dfb15629e02ea61072bfc905
git bisect good 2a2b0885664e318fe8162765b7286f1a6e9eb059
# good: [d9b974d73a61a3c7e80e196d9b26adb799a5c3a2] source
sha:1a45fd04cae6364f0f12e42a35beb1cce14a21f4
git bisect good d9b974d73a61a3c7e80e196d9b26adb799a5c3a2
# bad: [964016c59d5f9e94f8949967dfd527876abbff4b] source
sha:44250864a8252d29c87801a4530e3fe3efd01ba7
git bisect bad 964016c59d5f9e94f8949967dfd527876abbff4b
# bad: [f7afe646afb8cb49d5b434be49770617e1b8754b] source
sha:1c1f5ab3cb8f75ed386abd0b1a9a723555785766
git bisect bad f7afe646afb8cb49d5b434be49770617e1b8754b
# good: [073d3cac0cbd74cfc47fc6adf34e2ee43ec5999c] source
sha:c3695234916f86d6e929d59327db062f6bf90fef
git bisect good 073d3cac0cbd74cfc47fc6adf34e2ee43ec5999c
# bad: [2a2aa8404cb678e7ff4294f1acf4ab58290e0b42] source
sha:c47d0174f2c6c3ebcb3b33276d0277e7aceac330
git bisect bad 2a2aa8404cb678e7ff4294f1acf4ab58290e0b42
# good: [2db11ea03cbb90651544b1f706e0dd26a37566c6] source
sha:52800731baf9fcb88e54d60de5585640c8f97f7b
git bisect good 2db11ea03cbb90651544b1f706e0dd26a37566c6
# first bad commit: [2a2aa8404cb678e7ff4294f1acf4ab58290e0b42] source
sha:c47d0174f2c6c3ebcb3b33276d0277e7aceac330

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20190804/e77b45a6/attachment-0001.html>